Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: fpdfsdk/include/javascript/JS_Runtime.h

Issue 1367033002: Pass v8::Isolate to PDFium at init time. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: fix leak, clear globals while we're at it. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | fpdfsdk/include/jsapi/fxjs_v8.h » ('j') | fpdfsdk/src/fpdfview.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 7 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
8 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 8 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
9 9
10 #include <set> 10 #include <set>
11 #include <utility> 11 #include <utility>
12 12
13 #include "../../../third_party/base/nonstd_unique_ptr.h" 13 #include "../../../third_party/base/nonstd_unique_ptr.h"
Lei Zhang 2015/10/02 22:02:15 nit: Remove as well?
Tom Sepez 2015/10/02 22:46:50 Done.
14 #include "../../../core/include/fxcrt/fx_basic.h" 14 #include "../../../core/include/fxcrt/fx_basic.h"
15 #include "../jsapi/fxjs_v8.h" 15 #include "../jsapi/fxjs_v8.h"
Lei Zhang 2015/10/02 22:02:15 Also remove I think?
Tom Sepez 2015/10/02 22:46:50 Sorry, can't remove. This is how fpdfsdk/include/
16 #include "IJavaScript.h" 16 #include "IJavaScript.h"
17 #include "JS_EventHandler.h" 17 #include "JS_EventHandler.h"
18 18
19 class CJS_Context; 19 class CJS_Context;
20 20
21 class CJS_Runtime : public IFXJS_Runtime { 21 class CJS_Runtime : public IFXJS_Runtime {
22 public: 22 public:
23 using FieldEvent = std::pair<CFX_WideString, JS_EVENT_T>; 23 using FieldEvent = std::pair<CFX_WideString, JS_EVENT_T>;
24 24
25 explicit CJS_Runtime(CPDFDoc_Environment* pApp); 25 explicit CJS_Runtime(CPDFDoc_Environment* pApp);
(...skipping 22 matching lines...) Expand all
48 private: 48 private:
49 void DefineJSObjects(); 49 void DefineJSObjects();
50 50
51 CFX_ArrayTemplate<CJS_Context*> m_ContextArray; 51 CFX_ArrayTemplate<CJS_Context*> m_ContextArray;
52 CPDFDoc_Environment* m_pApp; 52 CPDFDoc_Environment* m_pApp;
53 CPDFSDK_Document* m_pDocument; 53 CPDFSDK_Document* m_pDocument;
54 FX_BOOL m_bBlocking; 54 FX_BOOL m_bBlocking;
55 std::set<FieldEvent> m_FieldEventSet; 55 std::set<FieldEvent> m_FieldEventSet;
56 v8::Isolate* m_isolate; 56 v8::Isolate* m_isolate;
57 bool m_isolateManaged; 57 bool m_isolateManaged;
58 nonstd::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator;
59 v8::Global<v8::Context> m_context; 58 v8::Global<v8::Context> m_context;
60 }; 59 };
61 60
62 #endif // FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 61 #endif // FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
OLDNEW
« no previous file with comments | « no previous file | fpdfsdk/include/jsapi/fxjs_v8.h » ('j') | fpdfsdk/src/fpdfview.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698