third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html - Issue 1366983003: Prevent CheckboxInputType from being freed by change event handlers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html

Issue 1366983003: Prevent CheckboxInputType from being freed by change event handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script src="../../../resources/js-test.js"></script>

	4 <label><input type=checkbox></label>

	5 <script>

	6 var label = document.querySelector('label');

	7 var checkbox = document.querySelector('input');

	8 checkbox.addEventListener('change', function() {

	9 this.removeAttribute('type');

	10 });

	11 label.click();

	12 </script>
	tkent 2015/09/25 04:35:13 Let's add what's the expected behavior. Add somet Let's add what's the expected behavior. Add something like the following after label.click(). testPassed("No crash after changing type on change event."); Oliver Chang 2015/09/25 04:48:34 Done. Show quoted text On 2015/09/25 04:35:13, tkent wrote: > Let's add what's the expected behavior. Add something like the following after > label.click(). > > testPassed("No crash after changing type on change event."); Done.
	13 </body>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free-expected.txt » ('j') | no next file with comments »