Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 136693020: Add image loading spec related tests (Closed)

Created:
6 years, 10 months ago by Yoav Weiss
Modified:
6 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add image loading spec related tests Added the following layout tests: * Setting order of crossOrigin and src attributes in JS doesn't change outgoing request * Setting order of srcset and src attributes in JS doesn't change fetched resources * Setting innerHTML with an <img> inside triggers a resource load * Setting src of a cached image exposes its width immediately BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166657

Patch Set 1 #

Patch Set 2 : Added srcset related tests #

Total comments: 2

Patch Set 3 : Fixed review comments #

Patch Set 4 : Added expectation for the origin header test #

Patch Set 5 : Fixed expectation for origin header test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -32 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLImageElement/image-dynamic-width.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLImageElement/image-dynamic-width-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/fast/dom/HTMLImageElement/image-innerHTML.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLImageElement/image-innerHTML-expected.txt View 1 chunk +3 lines, -5 lines 0 comments Download
M LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html View 1 2 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
A + LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A + LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/http/tests/images/image-with-origin-header.html View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/images/image-with-origin-header-expected.txt View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
A LayoutTests/http/tests/resources/origin.php View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/resources/square200.png View Binary file 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoav Weiss
Following a discussion on blink-dev [1] and on #whatwg [2], I've realized that there are ...
6 years, 10 months ago (2014-02-05 21:34:27 UTC) #1
Yoav Weiss
On 2014/02/05 21:34:27, Yoav Weiss wrote: > Following a discussion on blink-dev [1] and on ...
6 years, 10 months ago (2014-02-05 21:39:51 UTC) #2
abarth-chromium
LGTM https://codereview.chromium.org/136693020/diff/40001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/136693020/diff/40001/LayoutTests/TestExpectations#newcode113 LayoutTests/TestExpectations:113: crbug.com/341172 virtual/gpu/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html [ Failure ] Rather than making ...
6 years, 10 months ago (2014-02-06 01:11:18 UTC) #3
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 10 months ago (2014-02-06 20:19:57 UTC) #4
Yoav Weiss
The CQ bit was unchecked by yoav@yoav.ws
6 years, 10 months ago (2014-02-06 20:21:27 UTC) #5
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 10 months ago (2014-02-06 22:03:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/136693020/330001
6 years, 10 months ago (2014-02-06 22:03:34 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 23:13:00 UTC) #8
Message was sent while issue was closed.
Change committed as 166657

Powered by Google App Engine
This is Rietveld 408576698