LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html - Issue 136693020: Add image loading spec related tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html

Issue 136693020: Add image loading spec related tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed expectation for origin header test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt ('k') | LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html

diff --git a/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html b/LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html

similarity index 76%

copy from LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html

copy to LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html

index 5d86cfc99350559b2312003c0aa8fb7956b414c8..8e9eb2123877ee869cd4fb7c599a1eff4ec9ccc0 100644

--- a/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html

+++ b/LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html

@@ -1,20 +1,21 @@

<html>

<head>

- if (window.testRunner)

- testRunner.dumpResourceRequestCallbacks();

</script>

function updateSrc() {

var img = document.getElementById("foo");

- // srcset must be set first, otherwise 'src' is loaded as well

- img.srcset = "resources/blue-100-px-square.png 1x, resources/green-400-px-square.png 2x";

+ // The below should not trigger the load of the blue image according to the spec, but currently it does

+ // See http://crbug.com/341172

img.src = "resources/blue-100-px-square.png"

+ img.srcset = "resources/blue-100-px-square.png 1x, resources/green-400-px-square.png 2x";

}

addEventListener("DOMContentLoaded", function() {

+ if (window.testRunner && sessionStorage.pageReloaded)

+ testRunner.dumpResourceRequestCallbacks();

updateSrc();

}, false);

addEventListener("load", function() {