Refactoring ContentVideoViewContextDelegate.java

content/browser/android/content_video_view.h

Index: content/browser/android/content_video_view.h
diff --git a/content/browser/android/content_video_view.h b/content/browser/android/content_video_view.h
index deb5ffc7f11c91edb3a226ab7cf8395c49fec9de..9a994166d489372fb460c770446746fa2f7a9c6c 100644
--- a/content/browser/android/content_video_view.h
+++ b/content/browser/android/content_video_view.h
@@ -40,7 +40,9 @@ class ContentVideoView {
 
   // Method to create and destroy the Java view.
   void DestroyContentVideoView();
-  void CreateContentVideoView();
+  void CreateContentVideoView(
+      base::android::ScopedJavaLocalRef<jobject> context,
+      base::android::ScopedJavaLocalRef<jobject> content_video_view_client);

[joth, 2013/04/12 17:56:24]

you can pass these as "const JavaRef<jobject>&" to save on some ref count churn

[michaelbai, 2013/04/18 18:21:59]

Done.

 
   // Called when the Java fullscreen view is destroyed. If
   // |release_media_player| is true, |manager_| needs to release the player
@@ -68,9 +70,6 @@ class ContentVideoView {
   // handling all the playback controls.
   MediaPlayerManagerAndroid* manager_;
 
-  // Reference to the Java object.
-  base::android::ScopedJavaGlobalRef<jobject> j_content_video_view_;
-
   DISALLOW_COPY_AND_ASSIGN(ContentVideoView);
 };