Refactoring ContentVideoViewContextDelegate.java

content/browser/android/content_video_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIDEO_VIEW_H_
 #define CONTENT_BROWSER_ANDROID_CONTENT_VIDEO_VIEW_H_
 
 #include <jni.h>
 
 #include "base/android/scoped_java_ref.h"
@@ skipping 22 matching lines @@
   // Getter method called by the Java class to get the media information.
   int GetVideoWidth(JNIEnv*, jobject obj) const;
   int GetVideoHeight(JNIEnv*, jobject obj) const;
   int GetDurationInMilliSeconds(JNIEnv*, jobject obj) const;
   int GetCurrentPosition(JNIEnv*, jobject obj) const;
   bool IsPlaying(JNIEnv*, jobject obj);
   void UpdateMediaMetadata(JNIEnv*, jobject obj);
 
   // Method to create and destroy the Java view.
   void DestroyContentVideoView();
-  void CreateContentVideoView();
+  void CreateContentVideoView(
+      base::android::ScopedJavaLocalRef<jobject> context,
+      base::android::ScopedJavaLocalRef<jobject> content_video_view_client);

[joth, 2013/04/12 17:56:24]

you can pass these as "const JavaRef<jobject>&" to save on some ref count churn

[michaelbai, 2013/04/18 18:21:59]

Done.

 
   // Called when the Java fullscreen view is destroyed. If
   // |release_media_player| is true, |manager_| needs to release the player
   // as we are quitting the app.
   void ExitFullscreen(JNIEnv*, jobject, jboolean release_media_player);
 
   // Media control method called by the Java class.
   void SeekTo(JNIEnv*, jobject obj, jint msec);
   void Play(JNIEnv*, jobject obj);
   void Pause(JNIEnv*, jobject obj);
 
   // Called by the Java class to pass the surface object to the player.
   void SetSurface(JNIEnv*, jobject obj, jobject surface);
 
   // Method called by |manager_| to inform the Java class about player status
   // change.
   void UpdateMediaMetadata();
   void OnMediaPlayerError(int errorType);
   void OnVideoSizeChanged(int width, int height);
   void OnBufferingUpdate(int percent);
   void OnPlaybackComplete();
 
  private:
   // Object that manages the fullscreen media player. It is responsible for
   // handling all the playback controls.
   MediaPlayerManagerAndroid* manager_;
 
-  // Reference to the Java object.
-  base::android::ScopedJavaGlobalRef<jobject> j_content_video_view_;
-
   DISALLOW_COPY_AND_ASSIGN(ContentVideoView);
 };
 
 } // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_CONTENT_VIDEO_VIEW_H_