[turbofan] Make Node::set_op safer via wrapper.

[turbofan] Make Node::set_op safer via wrapper.

This introduces the NodeProperties::ChangeOp helper which guards node
operator changes so that additional checking can be done without any
additional dependencies being pulled into the Node class. For now only
the input count is checked, but additional checking might follow.

R=jarin@chromium.org

Committed: https://crrev.com/da9c42dd451bfdbe4a15cfe6c68fac544c3c515c
Cr-Commit-Position: refs/heads/master@{#30916}

[Jarin, 2015-09-24 11:59:18]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2015-09-24 11:59:18]

lgtm

[titzer, 2015-09-24 12:05:36]

titzer@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2015-09-24 12:05:37]

lgtm

[Michael Starzinger, 2015-09-24 13:51:46]

Going from work-in-progress to full-fledged-solution.

[Jarin, 2015-09-24 14:00:41]

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/control-fl...
File src/compiler/control-flow-optimizer.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/control-fl...
src/compiler/control-flow-optimizer.cc:264: NodeProperties::ChangeOp(node,
common()->Switch(values.size() + 1));
I am wondering whether ChangeOp should not be the last operation in any sequence
(so that if we check any consistency, we do not get spurious errors).

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/diamond.h
File src/compiler/diamond.h (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/diamond.h#...
src/compiler/diamond.h:64: NodeProperties::ChangeOp(node,
common->Phi(machine_type, 2));
Should not this go after trimming? (Same below.)

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-context...
File src/compiler/js-context-specialization.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-context...
src/compiler/js-context-specialization.cc:80: NodeProperties::ChangeOp(node,
op);
After ReplaceInput? (Here and below.)

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-intrins...
File src/compiler/js-intrinsic-lowering.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-intrins...
src/compiler/js-intrinsic-lowering.cc:539: NodeProperties::ChangeOp(
After replace inputs? (But be careful about the 'arity' variable here.)

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-typed-l...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:633: NodeProperties::ChangeOp(node,
simplified()->BooleanNot());
After ReplaceInput? (Here and below.)

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/machine-op...
File src/compiler/machine-operator-reducer.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/machine-op...
src/compiler/machine-operator-reducer.cc:216: NodeProperties::ChangeOp(node,
machine()->Int32Sub());
After ReplaceInput? (Here and below.)

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/simplified...
File src/compiler/simplified-operator-reducer.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/simplified...
src/compiler/simplified-operator-reducer.cc:103: NodeProperties::ChangeOp(node,
op);
After ReplaceInput?

[Michael Starzinger, 2015-09-24 14:21:28]

Addressed comments.

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/control-fl...
File src/compiler/control-flow-optimizer.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/control-fl...
src/compiler/control-flow-optimizer.cc:264: NodeProperties::ChangeOp(node,
common()->Switch(values.size() + 1));
On 2015/09/24 14:00:41, Jarin wrote:
> I am wondering whether ChangeOp should not be the last operation in any
sequence
> (so that if we check any consistency, we do not get spurious errors).

Done.

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/diamond.h
File src/compiler/diamond.h (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/diamond.h#...
src/compiler/diamond.h:64: NodeProperties::ChangeOp(node,
common->Phi(machine_type, 2));
On 2015/09/24 14:00:41, Jarin wrote:
> Should not this go after trimming? (Same below.)

Done. Dead code is being dead, gotta love it. :/

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-context...
File src/compiler/js-context-specialization.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-context...
src/compiler/js-context-specialization.cc:80: NodeProperties::ChangeOp(node,
op);
On 2015/09/24 14:00:41, Jarin wrote:
> After ReplaceInput? (Here and below.)

Done.

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-intrins...
File src/compiler/js-intrinsic-lowering.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-intrins...
src/compiler/js-intrinsic-lowering.cc:539: NodeProperties::ChangeOp(
On 2015/09/24 14:00:41, Jarin wrote:
> After replace inputs? (But be careful about the 'arity' variable here.)

Done. I was careful, it only fell to the ground twice while I moved it, but I
dusted it off and think we are fine. :)

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-typed-l...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:633: NodeProperties::ChangeOp(node,
simplified()->BooleanNot());
On 2015/09/24 14:00:41, Jarin wrote:
> After ReplaceInput? (Here and below.)

Done.

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/machine-op...
File src/compiler/machine-operator-reducer.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/machine-op...
src/compiler/machine-operator-reducer.cc:216: NodeProperties::ChangeOp(node,
machine()->Int32Sub());
On 2015/09/24 14:00:41, Jarin wrote:
> After ReplaceInput? (Here and below.)

Done.

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/simplified...
File src/compiler/simplified-operator-reducer.cc (right):

https://codereview.chromium.org/1366753003/diff/40001/src/compiler/simplified...
src/compiler/simplified-operator-reducer.cc:103: NodeProperties::ChangeOp(node,
op);
On 2015/09/24 14:00:41, Jarin wrote:
> After ReplaceInput?

Done.

[Michael Starzinger, 2015-09-24 14:44:35]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-09-24 14:44:35]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1366753003/#ps80001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-09-24 14:44:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366753003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366753003/80001

[commit-bot: I haz the power, 2015-09-24 14:46:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-24 14:46:47]

Patchset 5 (id:??) landed as
https://crrev.com/da9c42dd451bfdbe4a15cfe6c68fac544c3c515c
Cr-Commit-Position: refs/heads/master@{#30916}