Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: src/compiler/diamond.h

Issue 1366753003: [turbofan] Make Node::set_op safer via wrapper. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/dead-code-elimination.cc ('k') | src/compiler/js-context-specialization.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/diamond.h
diff --git a/src/compiler/diamond.h b/src/compiler/diamond.h
index cf83638bba8ddd6f6c501668d892c5d593cfc375..e6208e40aced7ddddb1e7029281ad8d18c31d218 100644
--- a/src/compiler/diamond.h
+++ b/src/compiler/diamond.h
@@ -8,6 +8,7 @@
#include "src/compiler/common-operator.h"
#include "src/compiler/graph.h"
#include "src/compiler/node.h"
+#include "src/compiler/node-properties.h"
namespace v8 {
namespace internal {
@@ -60,20 +61,20 @@ struct Diamond {
void OverwriteWithPhi(Node* node, MachineType machine_type, Node* tv,
Node* fv) {
DCHECK(node->InputCount() >= 3);
- node->set_op(common->Phi(machine_type, 2));
node->ReplaceInput(0, tv);
node->ReplaceInput(1, fv);
node->ReplaceInput(2, merge);
node->TrimInputCount(3);
+ NodeProperties::ChangeOp(node, common->Phi(machine_type, 2));
}
void OverwriteWithEffectPhi(Node* node, Node* te, Node* fe) {
DCHECK(node->InputCount() >= 3);
- node->set_op(common->EffectPhi(2));
node->ReplaceInput(0, te);
node->ReplaceInput(1, fe);
node->ReplaceInput(2, merge);
node->TrimInputCount(3);
+ NodeProperties::ChangeOp(node, common->EffectPhi(2));
}
};
}
« no previous file with comments | « src/compiler/dead-code-elimination.cc ('k') | src/compiler/js-context-specialization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698