Issue 1366563006: CFI: fix a bad cast from icu_54::Quantifier to icu_54::UnicodeSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1366563006: CFI: fix a bad cast from icu_54::Quantifier to icu_54::UnicodeSet. (Closed)

Created:
5 years, 3 months ago by krasin

Modified:
5 years, 2 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

CFI: fix a bad cast from icu_54::Quantifier to icu_54::UnicodeSet. Instead of casting icu_54::Quantifier* to its superclass icu_54::UnicodeFunctor*, there's a cast to another UnicodeFunctor* subclass, icu_54::UnicodeSet*. Looks like a accidental typo. This bug was found by Control Flow Integrity check: https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity BUG=chromium:528799

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	source/i18n/rbt_pars.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

krasin

5 years, 3 months ago (2015-09-25 02:15:38 UTC) #2

Hi Jungshik,

feel free to land this patch using ICU-specific way, if there's one.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages