Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1366443002: GN: Define clang_newlib_arm toolchain for NaCl (Closed)

Created:
5 years, 3 months ago by Roland McGrath
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Define clang_newlib_arm toolchain for NaCl Define the NaCl toolchain "clang_newlib_arm" with some refactoring. This makes it possible to build ppapi_nacl_tests on ARM, so enable that. Also let enable_nacl_browsertests=true function for machines other than x86-64, since that build more or less works now for all NaCl machines. R=dpranke@chromium.org BUG= Committed: https://crrev.com/8eea7d4bd41472136bf73dccd0d462bd4b2e8124 Cr-Commit-Position: refs/heads/master@{#350280}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M build/toolchain/nacl/BUILD.gn View 2 chunks +25 lines, -23 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M ppapi/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Roland McGrath
5 years, 3 months ago (2015-09-22 23:22:14 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/1366443002/diff/1/build/toolchain/nacl/BUILD.gn File build/toolchain/nacl/BUILD.gn (right): https://codereview.chromium.org/1366443002/diff/1/build/toolchain/nacl/BUILD.gn#newcode75 build/toolchain/nacl/BUILD.gn:75: assert(defined(invoker.toolchain_tuple), "Must define toolchain_tuple") tuples make me think ...
5 years, 3 months ago (2015-09-22 23:29:50 UTC) #2
Roland McGrath
bbudge: OWNERS review for ppapi/ sky or phajdan.jr: OWNERS review for chrome/test/ Thanks, Roland
5 years, 3 months ago (2015-09-22 23:31:38 UTC) #4
sky
LGTM
5 years, 3 months ago (2015-09-22 23:44:08 UTC) #5
bbudge
ppapi lgtm
5 years, 3 months ago (2015-09-23 00:00:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366443002/20001
5 years, 3 months ago (2015-09-23 00:04:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 00:39:35 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 00:40:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8eea7d4bd41472136bf73dccd0d462bd4b2e8124
Cr-Commit-Position: refs/heads/master@{#350280}

Powered by Google App Engine
This is Rietveld 408576698