Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6575)

Unified Diff: chrome/test/BUILD.gn

Issue 1366443002: GN: Define clang_newlib_arm toolchain for NaCl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/nacl/BUILD.gn ('k') | ppapi/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 460dcdea0d9ac07a107ae08849c05de60d444525..f621e0ec533a5baebaafdb3d134c9cb8e76e83ab 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -829,11 +829,6 @@ if (!is_android) {
"nacl/pnacl_header_test.h",
]
- # TODO(GYP): Make NaCl work in other configs and update the irt
- # dependency as appropriate. We should probably push this
- # dependency into ppapi/native_client so that clients don't need
- # to know all of the different toolchain options.
- assert(current_cpu == "x64")
data_deps += [
# "test/data/nacl:shared_test_files", # TODO(GYP) bug 512902
"//ppapi/native_client:irt",
@@ -868,7 +863,7 @@ if (!is_android) {
[ "//build/config/win:default_large_module_incremental_linking" ]
}
if (is_linux) {
- deps += [
+ data_deps += [
"//native_client/src/trusted/service_runtime/linux:munge_nacl_helper_bootstrap",
"//components/nacl:nacl_helper",
« no previous file with comments | « build/toolchain/nacl/BUILD.gn ('k') | ppapi/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698