Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 1366133002: [Telemetry] Test for display tracing (Closed)

Created:
5 years, 3 months ago by Zhen Wang
Modified:
5 years, 2 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Test for display tracing BUG=535731 Committed: https://crrev.com/b076edb74bbc896950af6e50c374c528ec0b4235 Cr-Commit-Position: refs/heads/master@{#351099}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -3 lines) Patch
M tools/telemetry/telemetry/internal/platform/android_platform_backend.py View 1 chunk +5 lines, -3 lines 0 comments Download
A tools/telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent_unittest.py View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Zhen Wang
ptal
5 years, 3 months ago (2015-09-24 23:47:09 UTC) #2
nednguyen
From the high level point of view, I think what we want to assert is ...
5 years, 2 months ago (2015-09-26 00:14:06 UTC) #3
Zhen Wang
updated the tests. https://codereview.chromium.org/1366133002/diff/1/tools/telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent_unittest.py File tools/telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent_unittest.py (right): https://codereview.chromium.org/1366133002/diff/1/tools/telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent_unittest.py#newcode14 tools/telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent_unittest.py:14: android_platform_backend.AndroidPlatformBackend): On 2015/09/26 00:14:06, nednguyen wrote: ...
5 years, 2 months ago (2015-09-28 15:40:58 UTC) #4
nednguyen
lgtm
5 years, 2 months ago (2015-09-28 16:41:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366133002/20001
5 years, 2 months ago (2015-09-28 16:43:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 19:19:03 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:19:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b076edb74bbc896950af6e50c374c528ec0b4235
Cr-Commit-Position: refs/heads/master@{#351099}

Powered by Google App Engine
This is Rietveld 408576698