tools/telemetry/telemetry/internal/platform/android_platform_backend.py - Issue 1366133002: [Telemetry] Test for display tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/android_platform_backend.py

Issue 1366133002: [Telemetry] Test for display tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/internal/platform/android_platform_backend.py

diff --git a/tools/telemetry/telemetry/internal/platform/android_platform_backend.py b/tools/telemetry/telemetry/internal/platform/android_platform_backend.py

index f40709e7c48cc0816336a50366e4e1d4025870d5..e574c9232f6eefeeaf13c3767edf9d6bd871b42f 100644

--- a/tools/telemetry/telemetry/internal/platform/android_platform_backend.py

+++ b/tools/telemetry/telemetry/internal/platform/android_platform_backend.py

@@ -228,9 +228,11 @@ class AndroidPlatformBackend(

if not self._surface_stats_collector:

return

- refresh_period, timestamps = self._surface_stats_collector.Stop()

- pid = self._surface_stats_collector.GetSurfaceFlingerPid()

- self._surface_stats_collector = None

+ try:

+ refresh_period, timestamps = self._surface_stats_collector.Stop()

+ pid = self._surface_stats_collector.GetSurfaceFlingerPid()

+ finally:

+ self._surface_stats_collector = None

# TODO(sullivan): should this code be inline, or live elsewhere?

events = []

for ts in timestamps:

« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent_unittest.py » ('j') | no next file with comments »