Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1366093004: Merge latest MB from trunk back to M46. (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
kerz_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@branch_2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Merge latest MB from trunk back to M46. In order to be able to build the official linux x64 builds with GN on trunk and GYP on the branches, we need to have the latest version of MB on the branches for consistency (so that we can flip configs without having to worry about not having all of the needful bug fixes on the branch). R=kerz@chromium.org BUG=530733 Committed: https://chromium.googlesource.com/chromium/src/+/0ec4c0e4978531d88f9fc903f4d82203d6fb3b28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -181 lines) Patch
M tools/mb/docs/user_guide.md View 3 chunks +2 lines, -5 lines 0 comments Download
M tools/mb/mb.py View 27 chunks +186 lines, -142 lines 0 comments Download
M tools/mb/mb_config.pyl View 12 chunks +74 lines, -17 lines 0 comments Download
M tools/mb/mb_unittest.py View 13 chunks +92 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
This is a straight copy of src/tools/mb@{#350953}. It picks up all of the bugfixes and ...
5 years, 2 months ago (2015-09-26 00:39:23 UTC) #1
Dirk Pranke
On 2015/09/26 00:39:23, Dirk Pranke wrote: > This is a straight copy of src/tools/mb@{#350953}. It ...
5 years, 2 months ago (2015-09-26 00:40:00 UTC) #2
kerz_chromium
lgtm I think it's fine.
5 years, 2 months ago (2015-09-26 03:10:53 UTC) #3
kerz_chromium
lgtm
5 years, 2 months ago (2015-09-26 03:11:03 UTC) #4
Dirk Pranke
5 years, 2 months ago (2015-09-28 18:30:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ec4c0e4978531d88f9fc903f4d82203d6fb3b28 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698