Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1365973002: Switch libvpx from static_library to none (Closed)

Created:
5 years, 2 months ago by Johann
Modified:
5 years, 2 months ago
Reviewers:
blundell
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : use export_dependent_settings instead of direct_dependent_settings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M libvpx.gyp View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Johann
gclient --runhooks and a build pass locally. I looked briefly for alternatives to dependencies and ...
5 years, 2 months ago (2015-09-24 16:33:06 UTC) #1
blundell
Thanks for following up here! I would run a clobber tryjob ("git cl try -c") ...
5 years, 2 months ago (2015-09-24 18:53:16 UTC) #2
Johann
Testing locally now. Need to land this and set up the roll to run trybots. ...
5 years, 2 months ago (2015-09-24 19:17:30 UTC) #3
Johann
On 2015/09/24 18:53:16, blundell wrote: > Thanks for following up here! I would run a ...
5 years, 2 months ago (2015-09-24 19:28:33 UTC) #4
blundell
LGTM Run the clobber tryjob on the CL rolling DEPS...that will ensure that all the ...
5 years, 2 months ago (2015-09-24 19:36:52 UTC) #5
Johann
5 years, 2 months ago (2015-09-24 19:51:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b33794b9132c8c1722206d6676c37177ccbaef2e.

Powered by Google App Engine
This is Rietveld 408576698