Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 1364033003: Use a group() instead of a static_library() (Closed)

Created:
5 years, 3 months ago by Johann
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use a group() instead of a static_library() Win8 builds are failing with an empty libvpx.lib Revert "Touch BUILD.gn to trigger a dependency" Keep the "public_configs" R=dpranke@chromium.org TBR=dpranke@chromium.org BUG=534943 Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/70db2235b7e389f4d1b178320ebce76280c127af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-23 23:41:49 UTC) #1
Johann
5 years, 3 months ago (2015-09-23 23:42:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
70db2235b7e389f4d1b178320ebce76280c127af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698