Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1365963007: Revert of Add CHECKs to help debug crashes exposed by adding a member to IPC::Message::Header. (Closed)

Created:
5 years, 2 months ago by erikchen
Modified:
5 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_content_checks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CHECKs to help debug crashes exposed by adding a member to IPC::Message::Header. (patchset #1 id:1 of https://codereview.chromium.org/1361903004/ ) Reason for revert: Crashes have been exposed. This CL is no longer needed. Original issue's description: > Add CHECKs to help debug crashes exposed by adding a member to IPC::Message::Header. > > This CL checks that the data_offset field of the ResourceMsg_DataReceived has > the appropriate range in both the sender and the receiver of the IPC message. > > BUG=527588 > > Committed: https://crrev.com/01d2c16fa0ae1952af0d5519d134f944f898f70f > Cr-Commit-Position: refs/heads/master@{#350421} TBR=avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527588 Committed: https://crrev.com/9c4295951b5e1587dd458de72f0abd86827b83ca Cr-Commit-Position: refs/heads/master@{#350879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
erikchen
Created Revert of Add CHECKs to help debug crashes exposed by adding a member to ...
5 years, 2 months ago (2015-09-25 19:07:04 UTC) #1
Avi (use Gerrit)
lgtm
5 years, 2 months ago (2015-09-25 19:09:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365963007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365963007/1
5 years, 2 months ago (2015-09-25 19:09:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 19:11:24 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 19:12:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c4295951b5e1587dd458de72f0abd86827b83ca
Cr-Commit-Position: refs/heads/master@{#350879}

Powered by Google App Engine
This is Rietveld 408576698