content/child/resource_dispatcher.cc - Issue 1365963007: Revert of Add CHECKs to help debug crashes exposed by adding a member to IPC::Message::Header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/resource_dispatcher.cc

Issue 1365963007: Revert of Add CHECKs to help debug crashes exposed by adding a member to IPC::Message::Header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ipc_content_checks

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/resource_dispatcher.cc

diff --git a/content/child/resource_dispatcher.cc b/content/child/resource_dispatcher.cc

index baf79aece718232c05fc097c35ff775116d35817..aeb1cbebc66081a825d767c136866c04d3bbe4fd 100644

--- a/content/child/resource_dispatcher.cc

+++ b/content/child/resource_dispatcher.cc

@@ -221,8 +221,6 @@

if (request_info && data_length > 0) {

CHECK(base::SharedMemory::IsHandleValid(request_info->buffer->handle()));

CHECK_GE(request_info->buffer_size, data_offset + data_length);

- // TODO(erikchen): Temporary debugging for http://crbug.com/527588.

- CHECK_LE(data_offset, 512 * 1024);

// Ensure that the SHM buffer remains valid for the duration of this scope.

// It is possible for Cancel() to be called before we exit this scope.

« no previous file with comments | « content/browser/loader/async_resource_handler.cc ('k') | no next file » | no next file with comments »