third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h - Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Worked on review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h

index 559efa3f0ab29b41b905e7146f86b552821267a5..7176e50c8afc29aa8b39a0c755343c4ae4b40eac 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h

@@ -35,7 +35,7 @@ public:

LayoutTextControlSingleLine(HTMLInputElement*);

~LayoutTextControlSingleLine() override;

// FIXME: Move createInnerEditorStyle() to TextControlInnerEditorElement.

- PassRefPtr<ComputedStyle> createInnerEditorStyle(const ComputedStyle& startStyle) const final;

+ PassRefPtr<ComputedStyle> createInnerEditorStyle(const ComputedStyle& startStyle) final;

void capsLockStateMayHaveChanged();

@@ -47,6 +47,7 @@ protected:

HTMLInputElement* inputElement() const;

private:

+ void addScrollbarPeudoStyle();

bool hasControlClip() const final;

LayoutRect controlClipRect(const LayoutPoint&) const final;

bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectTextField || LayoutTextControl::isOfType(type); }