Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Worked on review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 17 matching lines...) Expand all
28 28
29 namespace blink { 29 namespace blink {
30 30
31 class HTMLInputElement; 31 class HTMLInputElement;
32 32
33 class LayoutTextControlSingleLine : public LayoutTextControl { 33 class LayoutTextControlSingleLine : public LayoutTextControl {
34 public: 34 public:
35 LayoutTextControlSingleLine(HTMLInputElement*); 35 LayoutTextControlSingleLine(HTMLInputElement*);
36 ~LayoutTextControlSingleLine() override; 36 ~LayoutTextControlSingleLine() override;
37 // FIXME: Move createInnerEditorStyle() to TextControlInnerEditorElement. 37 // FIXME: Move createInnerEditorStyle() to TextControlInnerEditorElement.
38 PassRefPtr<ComputedStyle> createInnerEditorStyle(const ComputedStyle& startS tyle) const final; 38 PassRefPtr<ComputedStyle> createInnerEditorStyle(const ComputedStyle& startS tyle) final;
39 39
40 void capsLockStateMayHaveChanged(); 40 void capsLockStateMayHaveChanged();
41 41
42 protected: 42 protected:
43 virtual void centerContainerIfNeeded(LayoutBox*) const { } 43 virtual void centerContainerIfNeeded(LayoutBox*) const { }
44 virtual LayoutUnit computeLogicalHeightLimit() const; 44 virtual LayoutUnit computeLogicalHeightLimit() const;
45 Element* containerElement() const; 45 Element* containerElement() const;
46 Element* editingViewPortElement() const; 46 Element* editingViewPortElement() const;
47 HTMLInputElement* inputElement() const; 47 HTMLInputElement* inputElement() const;
48 48
49 private: 49 private:
50 void addScrollbarPeudoStyle();
50 bool hasControlClip() const final; 51 bool hasControlClip() const final;
51 LayoutRect controlClipRect(const LayoutPoint&) const final; 52 LayoutRect controlClipRect(const LayoutPoint&) const final;
52 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectTextField || LayoutTextControl::isOfType(type); } 53 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectTextField || LayoutTextControl::isOfType(type); }
53 54
54 void paint(const PaintInfo&, const LayoutPoint&) override; 55 void paint(const PaintInfo&, const LayoutPoint&) override;
55 void layout() override; 56 void layout() override;
56 57
57 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final; 58 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final;
58 59
59 void autoscroll(const IntPoint&) final; 60 void autoscroll(const IntPoint&) final;
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 return orientation == HorizontalScrollbar; 97 return orientation == HorizontalScrollbar;
97 } 98 }
98 bool scrollsOverflowX() const override { return hasOverflowClip(); } 99 bool scrollsOverflowX() const override { return hasOverflowClip(); }
99 bool scrollsOverflowY() const override { return false; } 100 bool scrollsOverflowY() const override { return false; }
100 bool hasLineIfEmpty() const override { return true; } 101 bool hasLineIfEmpty() const override { return true; }
101 }; 102 };
102 103
103 } 104 }
104 105
105 #endif 106 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698