third_party/sqlite/BUILD.gn - Issue 1365783002: Revert of [sql] Use memory-mapped I/O for sql::Connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/sqlite/BUILD.gn

Issue 1365783002: Revert of [sql] Use memory-mapped I/O for sql::Connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/sqlite/BUILD.gn

diff --git a/third_party/sqlite/BUILD.gn b/third_party/sqlite/BUILD.gn

index 76b92153f2292eeacdcfb864fe074e35af5c05c7..0daa5ee69daa7ae7d4315a5298673759152791dd 100644

--- a/third_party/sqlite/BUILD.gn

+++ b/third_party/sqlite/BUILD.gn

@@ -67,13 +67,6 @@

# prefer to control distribution to worker threads.

"SQLITE_MAX_WORKER_THREADS=0",

- # Allow 256MB mmap footprint per connection. Should not be too open-ended

- # as that could cause memory fragmentation. 50MB encompasses the 99th

- # percentile of Chrome databases in the wild.

- # TODO(shess): A 64-bit-specific value could be 1G or more.

- # TODO(shess): Figure out if exceeding this is costly.

- "SQLITE_MAX_MMAP_SIZE=268435456",

# Use a read-only memory map when mmap'ed I/O is enabled to prevent memory

# stompers from directly corrupting the database.

# TODO(shess): Upstream the ability to use this define.

« no previous file with comments | « sync/syncable/directory_backing_store.cc ('k') | third_party/sqlite/sqlite.gyp » ('j') | no next file with comments »