chrome/browser/ssl/ssl_blocking_page.h - Issue 1365733005: Split captive portal metrics out of SSLErrorClassification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 1365733005: Split captive portal metrics out of SSLErrorClassification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compiler error fix possibly for realsies Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ssl/ssl_blocking_page.h

diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h

index 0c45e31c4e12683610e57b96c5919111960d75b9..5387c81ab94cb3b3879e0f20984d8f48d69f6fb1 100644

--- a/chrome/browser/ssl/ssl_blocking_page.h

+++ b/chrome/browser/ssl/ssl_blocking_page.h

@@ -30,7 +30,6 @@ class PolicyTest_SSLErrorOverridingDisallowed_Test;

}

class CertReportHelper;

-class SSLErrorClassification;

// This class is responsible for showing/hiding the interstitial page that is

// shown when a certificate error happens.

@@ -121,7 +120,6 @@ class SSLBlockingPage : public SecurityInterstitialPage {

// Did the user previously allow a bad certificate but the decision has now

// expired?

const bool expired_but_previously_allowed_;

- scoped_ptr<SSLErrorClassification> ssl_error_classification_;

// The time at which the interstitial was triggered. The interstitial

// calculates all times relative to this.

« no previous file with comments | « chrome/browser/ssl/captive_portal_metrics_recorder.cc ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »