Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 1365733005: Split captive portal metrics out of SSLErrorClassification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compiler error fix possibly for realsies Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 5 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
6 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 6 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 12 matching lines...) Expand all
23 namespace extensions { 23 namespace extensions {
24 class ExperienceSamplingEvent; 24 class ExperienceSamplingEvent;
25 } 25 }
26 #endif 26 #endif
27 27
28 namespace policy { 28 namespace policy {
29 class PolicyTest_SSLErrorOverridingDisallowed_Test; 29 class PolicyTest_SSLErrorOverridingDisallowed_Test;
30 } 30 }
31 31
32 class CertReportHelper; 32 class CertReportHelper;
33 class SSLErrorClassification;
34 33
35 // This class is responsible for showing/hiding the interstitial page that is 34 // This class is responsible for showing/hiding the interstitial page that is
36 // shown when a certificate error happens. 35 // shown when a certificate error happens.
37 // It deletes itself when the interstitial page is closed. 36 // It deletes itself when the interstitial page is closed.
38 class SSLBlockingPage : public SecurityInterstitialPage { 37 class SSLBlockingPage : public SecurityInterstitialPage {
39 public: 38 public:
40 enum SSLBlockingPageOptionsMask { 39 enum SSLBlockingPageOptionsMask {
41 // Indicates whether or not the user could (assuming perfect knowledge) 40 // Indicates whether or not the user could (assuming perfect knowledge)
42 // successfully override the error and still get the security guarantees 41 // successfully override the error and still get the security guarantees
43 // of TLS. 42 // of TLS.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // danger_overridable_) By typing the word "danger". 113 // danger_overridable_) By typing the word "danger".
115 // - This is an undocumented workaround. 114 // - This is an undocumented workaround.
116 // - This can be set to "false" dynamically to prevent the behaviour. 115 // - This can be set to "false" dynamically to prevent the behaviour.
117 const bool overridable_; 116 const bool overridable_;
118 bool danger_overridable_; 117 bool danger_overridable_;
119 // Has the site requested strict enforcement of certificate errors? 118 // Has the site requested strict enforcement of certificate errors?
120 const bool strict_enforcement_; 119 const bool strict_enforcement_;
121 // Did the user previously allow a bad certificate but the decision has now 120 // Did the user previously allow a bad certificate but the decision has now
122 // expired? 121 // expired?
123 const bool expired_but_previously_allowed_; 122 const bool expired_but_previously_allowed_;
124 scoped_ptr<SSLErrorClassification> ssl_error_classification_;
125 123
126 // The time at which the interstitial was triggered. The interstitial 124 // The time at which the interstitial was triggered. The interstitial
127 // calculates all times relative to this. 125 // calculates all times relative to this.
128 const base::Time time_triggered_; 126 const base::Time time_triggered_;
129 127
130 scoped_ptr<CertReportHelper> cert_report_helper_; 128 scoped_ptr<CertReportHelper> cert_report_helper_;
131 129
132 DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage); 130 DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
133 }; 131 };
134 132
135 #endif // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 133 #endif // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
OLDNEW
« no previous file with comments | « chrome/browser/ssl/captive_portal_metrics_recorder.cc ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698