Add UMA histograms for more detailed latency tracking on the CRD host.

Add UMA histograms for more detailed latency tracking on the CRD host.

Previously only two delays in CRD hosts were tracked: capture time and
encode time. This CL adds 4 other values that are now measured on the
host, sent to the client and logged to UMA:
 - capture_pending_time: time between input event being received and
    when the next frame starts capturing.
 - capture_overhead_time: extra latency for the capturer caused by IPC
    and threading.
 - encode_pending_time: delay between capturer and encoder.
 - send_pending_time: time encoded packets wait in the send queue.

VideoFramePump is responsible for measuring all latency values sent to
the client except for capture_time_ms which is still measured by the
capturer.

Committed: https://crrev.com/752c6e600df859a34cedae1b9aa2ce26c198a77b
Cr-Commit-Position: refs/heads/master@{#351504}

[Sergey Ulanov, 2015-09-25 00:26:01]

sergeyu@chromium.org changed reviewers:
+ anandc@chromium.org, isherman@chromium.org, jamiewalch@chromium.org

[chromium-reviews, 2015-09-25 00:36:56]

On Thu, Sep 24, 2015 at 5:26 PM, <sergeyu@chromium.org> wrote:

> encode time. This CL adds 4 other values that are *not* measured on the
>

s/not/now?

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ilya Sherman, 2015-09-25 00:44:11]

histograms lgtm

[Sergey Ulanov, 2015-09-25 17:41:43]

On Thu, Sep 24, 2015 at 5:36 PM, Jamie Walch <jamiewalch@google.com> wrote:

>
>
> On Thu, Sep 24, 2015 at 5:26 PM, <sergeyu@chromium.org> wrote:
>
>> encode time. This CL adds 4 other values that are *not* measured on the
>>
>
> s/not/now?
>

Yes, fixed now. Thanks!

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[anandc, 2015-09-25 19:21:45]

LGTM % comment cleanup/nits.

https://codereview.chromium.org/1365663003/diff/1/remoting/host/video_frame_p...
File remoting/host/video_frame_pump.h (right):

https://codereview.chromium.org/1365663003/diff/1/remoting/host/video_frame_p...
remoting/host/video_frame_pump.h:103: // The following two field are set only
for one frame after each incoming
"fields"

https://codereview.chromium.org/1365663003/diff/1/remoting/host/video_frame_p...
remoting/host/video_frame_pump.h:139: // Task called when a frame has finished
decoding.
"finished encoding."

https://codereview.chromium.org/1365663003/diff/1/remoting/host/video_frame_p...
remoting/host/video_frame_pump.h:181: // Timestamps for the frame that's is
being captured.
Remove "is".

https://codereview.chromium.org/1365663003/diff/1/remoting/proto/video.proto
File remoting/proto/video.proto (right):

https://codereview.chromium.org/1365663003/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:75: // Time passed from when the last event was
received until capturing has
"Time between when the" etc., or just remove "passed".

https://codereview.chromium.org/1365663003/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:82: // Time passed between when the frame was
captured and when encoder started
Remove "passed".

https://codereview.chromium.org/1365663003/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:86: // Total latency for the event being blocked
until it's sent to the client.
"Time for which the event is blocked until it's sent to the client"?

[Sergey Ulanov, 2015-09-25 20:35:26]

https://codereview.chromium.org/1365663003/diff/1/remoting/host/video_frame_p...
File remoting/host/video_frame_pump.h (right):

https://codereview.chromium.org/1365663003/diff/1/remoting/host/video_frame_p...
remoting/host/video_frame_pump.h:103: // The following two field are set only
for one frame after each incoming
On 2015/09/25 19:21:45, anandc wrote:
> "fields"

Done.

https://codereview.chromium.org/1365663003/diff/1/remoting/host/video_frame_p...
remoting/host/video_frame_pump.h:139: // Task called when a frame has finished
decoding.
On 2015/09/25 19:21:44, anandc wrote:
> "finished encoding."

Done.

https://codereview.chromium.org/1365663003/diff/1/remoting/host/video_frame_p...
remoting/host/video_frame_pump.h:181: // Timestamps for the frame that's is
being captured.
On 2015/09/25 19:21:44, anandc wrote:
> Remove "is".

Done.

https://codereview.chromium.org/1365663003/diff/1/remoting/proto/video.proto
File remoting/proto/video.proto (right):

https://codereview.chromium.org/1365663003/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:75: // Time passed from when the last event was
received until capturing has
On 2015/09/25 19:21:45, anandc wrote:
> "Time between when the" etc., or just remove "passed".

Done.

https://codereview.chromium.org/1365663003/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:82: // Time passed between when the frame was
captured and when encoder started
On 2015/09/25 19:21:45, anandc wrote:
> Remove "passed".

Done.

https://codereview.chromium.org/1365663003/diff/1/remoting/proto/video.proto#...
remoting/proto/video.proto:86: // Total latency for the event being blocked
until it's sent to the client.
On 2015/09/25 19:21:45, anandc wrote:
> "Time for which the event is blocked until it's sent to the client"?

Done. It's also frame, not event

[Jamie, 2015-09-29 00:45:47]

lgtm

[Sergey Ulanov, 2015-09-29 16:09:02]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-09-29 16:09:02]

The patchset sent to the CQ was uploaded after l-g-t-m from anandc@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1365663003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-09-29 16:09:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365663003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365663003/20001

[commit-bot: I haz the power, 2015-09-29 16:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 16:38:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-09-30 05:15:46]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-09-30 05:15:47]

The patchset sent to the CQ was uploaded after l-g-t-m from anandc@chromium.org,
isherman@chromium.org, jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1365663003/#ps40001
(title: "fixed tests")

[commit-bot: I haz the power, 2015-09-30 05:16:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365663003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365663003/40001

[commit-bot: I haz the power, 2015-09-30 06:40:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-30 06:41:27]

Patchset 3 (id:??) landed as
https://crrev.com/752c6e600df859a34cedae1b9aa2ce26c198a77b
Cr-Commit-Position: refs/heads/master@{#351504}