Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1365623002: [turbofan] Elide fp32 convert for const compares (Closed)

Created:
5 years, 3 months ago by martyn.capewell
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Elide fp32 convert for const compares Reduce operations of the form f64cmp(fp32to64(x), k) to f32cmp(x, k) when k can be encoded as a 32-bit float. Committed: https://crrev.com/809f6b15be82e3b85425b5d9a45fe981d487bf43 Cr-Commit-Position: refs/heads/master@{#30909}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address pointer->reference nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -9 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/code-generator-impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 2 chunks +31 lines, -5 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 3 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
martyn.capewell
5 years, 3 months ago (2015-09-23 13:43:03 UTC) #2
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/1365623002/diff/1/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/1365623002/diff/1/src/compiler/machine-operator-reducer.cc#newcode1013 src/compiler/machine-operator-reducer.cc:1013: bool IsFloat64RepresentableAsFloat32(const Float64Matcher* m) { Nit: ...
5 years, 3 months ago (2015-09-23 17:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365623002/20001
5 years, 3 months ago (2015-09-24 11:02:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-24 11:24:30 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 11:24:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/809f6b15be82e3b85425b5d9a45fe981d487bf43
Cr-Commit-Position: refs/heads/master@{#30909}

Powered by Google App Engine
This is Rietveld 408576698