Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: src/compiler/arm/code-generator-arm.cc

Issue 1365623002: [turbofan] Elide fp32 convert for const compares (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address pointer->reference nit Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/arm/macro-assembler-arm.h" 7 #include "src/arm/macro-assembler-arm.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 __ teq(i.InputRegister(0), i.InputOperand2(1)); 565 __ teq(i.InputRegister(0), i.InputOperand2(1));
566 DCHECK_EQ(SetCC, i.OutputSBit()); 566 DCHECK_EQ(SetCC, i.OutputSBit());
567 break; 567 break;
568 case kArmVcmpF32: 568 case kArmVcmpF32:
569 if (instr->InputAt(1)->IsDoubleRegister()) { 569 if (instr->InputAt(1)->IsDoubleRegister()) {
570 __ VFPCompareAndSetFlags(i.InputFloat32Register(0), 570 __ VFPCompareAndSetFlags(i.InputFloat32Register(0),
571 i.InputFloat32Register(1)); 571 i.InputFloat32Register(1));
572 } else { 572 } else {
573 DCHECK(instr->InputAt(1)->IsImmediate()); 573 DCHECK(instr->InputAt(1)->IsImmediate());
574 // 0.0 is the only immediate supported by vcmp instructions. 574 // 0.0 is the only immediate supported by vcmp instructions.
575 DCHECK(i.InputDouble(1) == 0.0); 575 DCHECK(i.InputFloat32(1) == 0.0f);
576 __ VFPCompareAndSetFlags(i.InputFloat32Register(0), i.InputDouble(1)); 576 __ VFPCompareAndSetFlags(i.InputFloat32Register(0), i.InputFloat32(1));
577 } 577 }
578 DCHECK_EQ(SetCC, i.OutputSBit()); 578 DCHECK_EQ(SetCC, i.OutputSBit());
579 break; 579 break;
580 case kArmVaddF32: 580 case kArmVaddF32:
581 __ vadd(i.OutputFloat32Register(), i.InputFloat32Register(0), 581 __ vadd(i.OutputFloat32Register(), i.InputFloat32Register(0),
582 i.InputFloat32Register(1)); 582 i.InputFloat32Register(1));
583 DCHECK_EQ(LeaveCC, i.OutputSBit()); 583 DCHECK_EQ(LeaveCC, i.OutputSBit());
584 break; 584 break;
585 case kArmVsubF32: 585 case kArmVsubF32:
586 __ vsub(i.OutputFloat32Register(), i.InputFloat32Register(0), 586 __ vsub(i.OutputFloat32Register(), i.InputFloat32Register(0),
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
1261 padding_size -= v8::internal::Assembler::kInstrSize; 1261 padding_size -= v8::internal::Assembler::kInstrSize;
1262 } 1262 }
1263 } 1263 }
1264 } 1264 }
1265 1265
1266 #undef __ 1266 #undef __
1267 1267
1268 } // namespace compiler 1268 } // namespace compiler
1269 } // namespace internal 1269 } // namespace internal
1270 } // namespace v8 1270 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698