Issue 1365503003: Merge to XFA: Use std::set<> to track active event handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1365503003: Merge to XFA: Use std::set<> to track active event handlers. (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Use std::set<> to track active event handlers. Merge conflicts in JS_Runtime.cpp (cherry picked from commit d8d223127d706aa4961b2c9b0037ab256fce9a8f) Original Review URL: https://codereview.chromium.org/1352393003 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5d0e8432c63a5e7a0b42fd4621c1c454ff49985e

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -88 lines)			Patch
M	fpdfsdk/include/javascript/JS_Runtime.h	View		4 chunks	+9 lines, -13 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Context.cpp	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	1	3 chunks	+4 lines, -70 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 3 months ago (2015-09-22 22:50:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5d0e8432c63a5e7a0b42fd4621c1c454ff49985e (presubmit successful).