Use std::set<> to track active event handlers.

Use std::set<> to track active event handlers.

This avoids some custom linked-list code. Also note that
we use a local copy to be sure we removed the same thing
that was added no matter how our callees may muck with the
handler.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/d8d223127d706aa4961b2c9b0037ab256fce9a8f

[Tom Sepez, 2015-09-22 17:02:16]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-09-22 17:02:17]

Lei, for review.

[Lei Zhang, 2015-09-22 22:20:50]

SGTM

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/JS_Runtime.h (right):

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/JS_Runtime.h:37: FX_BOOL AddEventToSet(const
FieldEvent& event);
Can we use bool in new code?

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/src/javascript/JS_R...
File fpdfsdk/src/javascript/JS_Runtime.cpp (right):

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/src/javascript/JS_R...
fpdfsdk/src/javascript/JS_Runtime.cpp:173: if (m_FieldEventSet.find(event) !=
m_FieldEventSet.end())
Alternatively, you can skip this and just insert(). Then check the second part
of the returned pair.

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/src/javascript/JS_R...
fpdfsdk/src/javascript/JS_Runtime.cpp:183: m_FieldEventSet.erase(iter);
Similarly, just erase |event| and it'll do a find() internally.

[Tom Sepez, 2015-09-22 22:32:46]

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/JS_Runtime.h (right):

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/JS_Runtime.h:37: FX_BOOL AddEventToSet(const
FieldEvent& event);
On 2015/09/22 22:20:50, Lei Zhang wrote:
> Can we use bool in new code?

Done.

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/src/javascript/JS_R...
File fpdfsdk/src/javascript/JS_Runtime.cpp (right):

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/src/javascript/JS_R...
fpdfsdk/src/javascript/JS_Runtime.cpp:173: if (m_FieldEventSet.find(event) !=
m_FieldEventSet.end())
On 2015/09/22 22:20:50, Lei Zhang wrote:
> Alternatively, you can skip this and just insert(). Then check the second part
> of the returned pair.

Done.

https://codereview.chromium.org/1352393003/diff/1/fpdfsdk/src/javascript/JS_R...
fpdfsdk/src/javascript/JS_Runtime.cpp:183: m_FieldEventSet.erase(iter);
On 2015/09/22 22:20:50, Lei Zhang wrote:
> Similarly, just erase |event| and it'll do a find() internally.

Done.

[Lei Zhang, 2015-09-22 22:36:56]

lgtm

[Tom Sepez, 2015-09-22 22:39:20]

Committed patchset #2 (id:20001) manually as
d8d223127d706aa4961b2c9b0037ab256fce9a8f (presubmit successful).