Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

Issue 1365433002: Add setSelection function to automation API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nobrailleautostartintests
Patch Set: Change setDocumentSelection to take named arguments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
diff --git a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
index afd510a2e2bcd2f0ad2e5e17fcfde827028bc1b4..402cbcf64b2fd1aad2b375f8937ef791c745abda 100644
--- a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
+++ b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
@@ -169,8 +169,12 @@ class RenderFrameHostActionAdapter : public AutomationActionAdapter {
rfh_->AccessibilityScrollToMakeVisible(id, gfx::Rect());
}
- void SetSelection(int32 id, int32 start, int32 end) override {
- rfh_->AccessibilitySetTextSelection(id, start, end);
+ void SetSelection(int32 anchor_id,
+ int32 anchor_offset,
+ int32 focus_id,
+ int32 focus_offset) override {
+ rfh_->AccessibilitySetSelection(anchor_id, anchor_offset, focus_id,
+ focus_offset);
}
void ShowContextMenu(int32 id) override {
@@ -360,9 +364,9 @@ AutomationInternalPerformActionFunction::RouteActionToAdapter(
EXTENSION_FUNCTION_VALIDATE(
api::automation_internal::SetSelectionParams::Populate(
params->opt_args.additional_properties, &selection_params));
- adapter->SetSelection(automation_id,
- selection_params.start_index,
- selection_params.end_index);
+ adapter->SetSelection(automation_id, selection_params.anchor_offset,
+ selection_params.focus_node_id,
+ selection_params.focus_offset);
break;
}
case api::automation_internal::ACTION_TYPE_SHOWCONTEXTMENU: {

Powered by Google App Engine
This is Rietveld 408576698