chrome/browser/extensions/api/automation_internal/automation_action_adapter.h - Issue 1365433002: Add setSelection function to automation API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_action_adapter.h

Issue 1365433002: Add setSelection function to automation API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nobrailleautostartintests

Patch Set: Change setDocumentSelection to take named arguments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/automation/automation_apitest.cc ('k') | chrome/browser/extensions/api/automation_internal/automation_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/automation_internal/automation_action_adapter.h

diff --git a/chrome/browser/extensions/api/automation_internal/automation_action_adapter.h b/chrome/browser/extensions/api/automation_internal/automation_action_adapter.h

index 1bb98bcafb191638fda9614f4a0cc38996e7c2a3..d3a6f1e14eaa82d0c9e2856cd83a5bb90cd1bb7b 100644

--- a/chrome/browser/extensions/api/automation_internal/automation_action_adapter.h

+++ b/chrome/browser/extensions/api/automation_internal/automation_action_adapter.h

@@ -22,9 +22,12 @@ class AutomationActionAdapter {

// shown.

virtual void MakeVisible(int32 id) = 0;

- // Sets selection for a start and end index (usually only relevant on text

- // fields).

- virtual void SetSelection(int32 id, int32 start, int32 end) = 0;

+ // Sets selection for anchor and focus node/offset pairs. Also used to set

+ // selection in text fields.

+ virtual void SetSelection(int32 anchor_id,

+ int32 anchor_offset,

+ int32 focus_id,

+ int32 focus_offset) = 0;

// Shows the context menu resulting from a right click.

virtual void ShowContextMenu(int32 id) = 0;