Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1365393002: [GN]: Fix bug in roller script with try servers (Closed)

Created:
5 years, 2 months ago by Bons
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN]: Fix bug in roller script with try servers The API endpoint being used appears to be broken. There is a direct URL to the try_server_results data, so use that. BUG=none Committed: https://crrev.com/e1bbf3218766ea727b229398aaae0df17fe3856b Cr-Commit-Position: refs/heads/master@{#350906}

Patch Set 1 #

Patch Set 2 : s/DEPS/buildtools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tools/gn/bin/roll_gn.py View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Bons
5 years, 2 months ago (2015-09-25 20:18:50 UTC) #2
Dirk Pranke
Hm. The old api was working for me as of a couple days ago, though ...
5 years, 2 months ago (2015-09-25 20:28:56 UTC) #3
Bons
It's returning an empty array. Issue: https://codereview.chromium.org/1366253004/ Busted tryjob data url: https://codereview.chromium.org/api/1359133003/1/ New data url: ...
5 years, 2 months ago (2015-09-25 20:30:26 UTC) #4
Dirk Pranke
Hm. That looks like a regression. Mind filing a bug? lgtm to switch to the ...
5 years, 2 months ago (2015-09-25 20:32:50 UTC) #5
Bons
Sure. Also updated description to say 'Roll buildtools' On Fri, Sep 25, 2015 at 4:32 ...
5 years, 2 months ago (2015-09-25 20:33:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365393002/20001
5 years, 2 months ago (2015-09-25 20:36:17 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-25 20:36:19 UTC) #10
Bons
On 2015/09/25 20:36:19, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 2 months ago (2015-09-25 20:39:46 UTC) #11
Dirk Pranke
On 2015/09/25 20:36:19, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 2 months ago (2015-09-25 20:40:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365393002/20001
5 years, 2 months ago (2015-09-25 20:41:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 20:53:00 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 20:53:35 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1bbf3218766ea727b229398aaae0df17fe3856b
Cr-Commit-Position: refs/heads/master@{#350906}

Powered by Google App Engine
This is Rietveld 408576698