|
|
Created:
5 years, 2 months ago by Bons Modified:
5 years, 2 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[GN]: Fix bug in roller script with try servers
The API endpoint being used appears to be broken. There is a direct URL
to the try_server_results data, so use that.
BUG=none
Committed: https://crrev.com/e1bbf3218766ea727b229398aaae0df17fe3856b
Cr-Commit-Position: refs/heads/master@{#350906}
Patch Set 1 #Patch Set 2 : s/DEPS/buildtools #Messages
Total messages: 16 (4 generated)
andybons@chromium.org changed reviewers: + dpranke@chromium.org
Hm. The old api was working for me as of a couple days ago, though your fix is probably better regardless. What sort of error are you getting?
It's returning an empty array. Issue: https://codereview.chromium.org/1366253004/ Busted tryjob data url: https://codereview.chromium.org/api/1359133003/1/ New data url: https://codereview.chromium.org/api/1359133003/1/try_job_results On Fri, Sep 25, 2015 at 4:28 PM <dpranke@chromium.org> wrote: > Hm. The old api was working for me as of a couple days ago, though your fix > is > probably better regardless. > > What sort of error are you getting? > > https://codereview.chromium.org/1365393002/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Hm. That looks like a regression. Mind filing a bug? lgtm to switch to the updated endpoint, though. On Fri, Sep 25, 2015 at 1:30 PM, Andrew Bonventre <andybons@chromium.org> wrote: > It's returning an empty array. > > Issue: https://codereview.chromium.org/1366253004/ > Busted tryjob data url: https://codereview.chromium.org/api/1359133003/1/ > New data url: > https://codereview.chromium.org/api/1359133003/1/try_job_results > > On Fri, Sep 25, 2015 at 4:28 PM <dpranke@chromium.org> wrote: > >> Hm. The old api was working for me as of a couple days ago, though your >> fix >> is >> probably better regardless. >> >> What sort of error are you getting? >> >> https://codereview.chromium.org/1365393002/ >> > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Sure. Also updated description to say 'Roll buildtools' On Fri, Sep 25, 2015 at 4:32 PM Dirk Pranke <dpranke@chromium.org> wrote: > Hm. That looks like a regression. Mind filing a bug? > > lgtm to switch to the updated endpoint, though. > > On Fri, Sep 25, 2015 at 1:30 PM, Andrew Bonventre <andybons@chromium.org> > wrote: > >> It's returning an empty array. >> >> Issue: https://codereview.chromium.org/1366253004/ >> Busted tryjob data url: https://codereview.chromium.org/api/1359133003/1/ >> New data url: >> https://codereview.chromium.org/api/1359133003/1/try_job_results >> >> On Fri, Sep 25, 2015 at 4:28 PM <dpranke@chromium.org> wrote: >> >>> Hm. The old api was working for me as of a couple days ago, though your >>> fix >>> is >>> probably better regardless. >>> >>> What sort of error are you getting? >>> >>> https://codereview.chromium.org/1365393002/ >>> >> > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by andybons@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365393002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2015/09/25 20:36:19, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. Only full committers are accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Sigh. Looks like it didn't pick up your lgtm, Dirk.
On 2015/09/25 20:36:19, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. Only full committers are accepted. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. that's weird. lgtm .
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365393002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e1bbf3218766ea727b229398aaae0df17fe3856b Cr-Commit-Position: refs/heads/master@{#350906} |