Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tools/gn/bin/roll_gn.py

Issue 1365393002: [GN]: Fix bug in roller script with try servers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/DEPS/buildtools Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/bin/roll_gn.py
diff --git a/tools/gn/bin/roll_gn.py b/tools/gn/bin/roll_gn.py
index f02ba8b67aac138d6d75c898b776cf5680b1a693..a479bdcf49126ad5d9dae6b9cfd3e87bde86ed79 100644
--- a/tools/gn/bin/roll_gn.py
+++ b/tools/gn/bin/roll_gn.py
@@ -206,12 +206,11 @@ class GNRoller(object):
patchset = int(props['patchsets'][-1])
try:
- patchset_data = json.loads(rpc_server.Send('/api/%d/%d' %
- (issue, patchset)))
+ try_job_results = json.loads(rpc_server.Send(
+ '/api/%d/%d/try_job_results' % (issue, patchset)))
except Exception as _e:
raise
- try_job_results = patchset_data['try_job_results']
if not try_job_results:
print('No try jobs found on most recent patchset')
return {}
@@ -375,7 +374,7 @@ class GNRoller(object):
gn_changes = self.GetGNChanges()
return (
- 'Roll DEPS %s..%s\n'
+ 'Roll buildtools %s..%s\n'
'\n'
' In order to roll GN %s..%s (r%s:r%s) and pick up\n'
' the following changes:\n'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698