Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 1365383004: Cleanup: Remove internal two-phase data pipe all-or-none support. (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Cleanup: Remove internal two-phase data pipe all-or-none support. BUG=Fixes #366 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8cb0c854439f1de7a3e1364c87b0ce9999ca746a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -315 lines) Patch
M mojo/edk/system/data_pipe.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 3 chunks +4 lines, -22 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 32 chunks +41 lines, -219 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.cc View 3 chunks +2 lines, -17 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.cc View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 2 months ago (2015-09-25 23:59:41 UTC) #1
jamesr
lgtm
5 years, 2 months ago (2015-09-26 00:38:09 UTC) #2
viettrungluu
5 years, 2 months ago (2015-09-26 00:45:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8cb0c854439f1de7a3e1364c87b0ce9999ca746a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698