mojo/edk/system/data_pipe_consumer_dispatcher.cc - Issue 1365383004: Cleanup: Remove internal two-phase data pipe all-or-none support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/data_pipe_consumer_dispatcher.cc

Issue 1365383004: Cleanup: Remove internal two-phase data pipe all-or-none support. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/edk/system/data_pipe_consumer_dispatcher.cc

diff --git a/mojo/edk/system/data_pipe_consumer_dispatcher.cc b/mojo/edk/system/data_pipe_consumer_dispatcher.cc

index 0821c64e87b49858b6df2101287beb17dad76cf4..059f80127f6669a54819c47a14fef2f52f630ad0 100644

--- a/mojo/edk/system/data_pipe_consumer_dispatcher.cc

+++ b/mojo/edk/system/data_pipe_consumer_dispatcher.cc

@@ -112,8 +112,7 @@ MojoResult DataPipeConsumerDispatcher::BeginReadDataImplNoLock(

(flags & MOJO_READ_DATA_FLAG_QUERY) || (flags & MOJO_READ_DATA_FLAG_PEEK))

return MOJO_RESULT_INVALID_ARGUMENT;

- // TODO(vtl): Remove all-or-none support at lower levels.

- return data_pipe_->ConsumerBeginReadData(buffer, buffer_num_bytes, false);

+ return data_pipe_->ConsumerBeginReadData(buffer, buffer_num_bytes);

}

MojoResult DataPipeConsumerDispatcher::EndReadDataImplNoLock(

« no previous file with comments | « mojo/edk/system/data_pipe.cc ('k') | mojo/edk/system/data_pipe_impl.h » ('j') | no next file with comments »