Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1365263002: Update composed tree version of isEndOfEditableOrNonEditableContent() (Closed)

Created:
2 years, 2 months ago by yosin_UTC9
Modified:
2 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, yoichio
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update composed tree version of isEndOfEditableOrNonEditableContent() to handle a positions in INPUT/TEXTAREA element This patch makes composed tree version of |isEndOfEditableOrNonEditableContent()| to handle a position in INPUT/TEXTAREA element as same as DOM tree version as a preparation of introducing full version of |VisibleSelectionTemplate|. Before this patch, composed tree version of |isEndOfEditableOrNonEditableContent()| returns false for the last position of inner editor in INPUT/TEXTAREA element, but DOM version of it returns true. Because of the last position of inner editor is the last position of shadow DOM tree and there are no next position. However, in composed tree, next position of the last position of inner editor is a position after INPUT/TEXTAREA element. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1363873004 BUG=513568 TEST=VisibleUnitsTest.isEndOfEditableOrNonEditableContentWithInput Committed: https://crrev.com/311966e56451f2b03668a4866fb7a886a0e05ad9 Cr-Commit-Position: refs/heads/master@{#350803}

Patch Set 1 : 2015-09-25T15:29:49 #

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
2 years, 2 months ago (2015-09-25 07:21:24 UTC) #2
tkent
lgtm
2 years, 2 months ago (2015-09-25 09:18:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365263002/1
2 years, 2 months ago (2015-09-25 09:18:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 1 month ago (2015-09-25 11:21:48 UTC) #6
commit-bot: I haz the power
2 years, 1 month ago (2015-09-25 11:23:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/311966e56451f2b03668a4866fb7a886a0e05ad9
Cr-Commit-Position: refs/heads/master@{#350803}

Powered by Google App Engine
This is Rietveld efc10ee0f