chrome/common/extensions/manifest_url_handler.cc - Issue 13652010: Add a virtual keyboard webui at chrome://keyboard/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_url_handler.cc

Issue 13652010: Add a virtual keyboard webui at chrome://keyboard/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest_url_handler.cc

diff --git a/chrome/common/extensions/manifest_url_handler.cc b/chrome/common/extensions/manifest_url_handler.cc

index 2299ec57544e4e2c552ba8d29ea51566d2615cf4..a3f83068a0f3b504b9a2e97ddcf9c37b5ecc5d28 100644

--- a/chrome/common/extensions/manifest_url_handler.cc

+++ b/chrome/common/extensions/manifest_url_handler.cc

@@ -273,6 +273,9 @@ bool URLOverridesHandler::Parse(Extension* extension, string16* error) {

!(extension->location() == Manifest::COMPONENT &&

page == chrome::kChromeUIFileManagerHost));

#endif

+ // FIXME(bryeung): figure out where this should be enabled

+ is_override = (is_override &&

+ page != chrome::kChromeUIVirtualKeyboardHost);

if (is_override || !iter.value().GetAsString(&val)) {

*error = ASCIIToUTF16(errors::kInvalidChromeURLOverrides);