Add a virtual keyboard webui at chrome://keyboard/

Add a virtual keyboard webui at chrome://keyboard/

This is just the old virtual keyboard that was removed a couple of years
ago, being used as a temporary stand-in.

BUG=222801
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194579

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194635

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194881

[bryeung, 2013-04-04 21:50:31]

Sadrul: I forget what we discussed.  Do the webui files need to move to
ui/keyboard/?

[sadrul, 2013-04-04 22:13:43]

On 2013/04/04 21:50:31, bryeung wrote:
> Sadrul: I forget what we discussed.  Do the webui files need to move to
> ui/keyboard/?

I think the files can stay here in chrome/browser/resources/ for now. It may
make sense to move it into ui/keyboard/ at some point, but it's not necessary
yet.

I don't know much about the extension code. So removing myself from the reviewer
list. Perhaps an OWNER can review?

[bshe, 2013-04-04 23:55:25]

https://codereview.chromium.org/13652010/diff/1/chrome/browser/resources/virt...
File chrome/browser/resources/virtual_keyboard/layout_us.js (right):

https://codereview.chromium.org/13652010/diff/1/chrome/browser/resources/virt...
chrome/browser/resources/virtual_keyboard/layout_us.js:16: new
SpecialKey('space', ' ', 'Spacebar'),
drive by: this is probably included accidentally?

https://codereview.chromium.org/13652010/diff/1/chrome/browser/resources/virt...
chrome/browser/resources/virtual_keyboard/layout_us.js:80: new
SpecialKey('space', ' ', 'Spacebar'),
drive by: this should probably be:
    new SvgKey('mic', ''),
    new DotComKey(),
    new SpecialKey('at', '@', '@'),
    // TODO(bryeung): the spacebar needs to be a little bit more stretchy,
    // since this row has only 7 keys (as opposed to 12), the truncation
    // can cause it to not be wide enough.
    new SpecialKey('space', ' ', 'Spacebar'),
    new SpecialKey('comma', ',', ','),
    new SpecialKey('period', '.', '.'),
    new HideKeyboardKey()

[bryeung, 2013-04-05 17:17:46]

Good catches: thanks Biao!

https://codereview.chromium.org/13652010/diff/1/chrome/browser/resources/virt...
File chrome/browser/resources/virtual_keyboard/layout_us.js (right):

https://codereview.chromium.org/13652010/diff/1/chrome/browser/resources/virt...
chrome/browser/resources/virtual_keyboard/layout_us.js:80: new
SpecialKey('space', ' ', 'Spacebar'),
On 2013/04/04 23:55:25, bshe wrote:
> drive by: this should probably be:
>     new SvgKey('mic', ''),
>     new DotComKey(),
>     new SpecialKey('at', '@', '@'),
>     // TODO(bryeung): the spacebar needs to be a little bit more stretchy,
>     // since this row has only 7 keys (as opposed to 12), the truncation
>     // can cause it to not be wide enough.
>     new SpecialKey('space', ' ', 'Spacebar'),
>     new SpecialKey('comma', ',', ','),
>     new SpecialKey('period', '.', '.'),
>     new HideKeyboardKey()

Done.

[bryeung, 2013-04-14 15:46:56]

Sadrul: I've added you back as a reviewer now that this is moved to src/ui.

I've omitted the WebUI handler for now: I'll add that in a follow-up CL if you
don't mind.

[bryeung, 2013-04-14 15:47:49]

+asargent: for extensions portion

[sadrul, 2013-04-15 17:17:27]

I mainly looked at the .cc/.h files in ui/keyboard/. LGTM

https://codereview.chromium.org/13652010/diff/20001/chrome/browser/extensions...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/13652010/diff/20001/chrome/browser/extensions...
chrome/browser/extensions/component_loader.cc:340:
base::FilePath(FILE_PATH_LITERAL("keyboard")));
Did you plan on using |id|?

https://codereview.chromium.org/13652010/diff/20001/ui/keyboard/keyboard_ui_c...
File ui/keyboard/keyboard_ui_controller.cc (right):

https://codereview.chromium.org/13652010/diff/20001/ui/keyboard/keyboard_ui_c...
ui/keyboard/keyboard_ui_controller.cc:17:
content::WebUIDataSource::Create("keyboard");
s/"keyboard"/keyboard::kKeyboardWebUIHost/ ?

[bryeung, 2013-04-15 17:50:56]

https://codereview.chromium.org/13652010/diff/20001/chrome/browser/extensions...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/13652010/diff/20001/chrome/browser/extensions...
chrome/browser/extensions/component_loader.cc:340:
base::FilePath(FILE_PATH_LITERAL("keyboard")));
On 2013/04/15 17:17:27, sadrul wrote:
> Did you plan on using |id|?

Leftover from debugging (where I was LOG'ing it).  Good catch.

https://codereview.chromium.org/13652010/diff/20001/ui/keyboard/keyboard_ui_c...
File ui/keyboard/keyboard_ui_controller.cc (right):

https://codereview.chromium.org/13652010/diff/20001/ui/keyboard/keyboard_ui_c...
ui/keyboard/keyboard_ui_controller.cc:17:
content::WebUIDataSource::Create("keyboard");
On 2013/04/15 17:17:27, sadrul wrote:
> s/"keyboard"/keyboard::kKeyboardWebUIHost/ ?

Also good catch :-)  Done.

[asargent_no_longer_on_chrome, 2013-04-15 18:47:38]

extensions parts lgtm

[bryeung, 2013-04-16 14:09:19]

+ben for OWNERS

[Ben Goodger (Google), 2013-04-16 16:37:30]

lgtm

[bryeung, 2013-04-17 12:32:28]

Committed patchset #9 manually as r194579 (presubmit successful).

[bryeung, 2013-04-17 17:58:29]

Committed patchset #11 manually as r194635 (presubmit successful).

[bryeung, 2013-04-18 11:24:05]

Committed patchset #13 manually as r194881 (presubmit successful).