Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 13649007: Browser Plugin: Simplify NewWindow code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 605cafca7edd9652bd7f986326d9228931ea6238..5df45b493e683915e8a4936074d7d5f6c81ac5f4 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -195,9 +195,6 @@ class CONTENT_EXPORT BrowserPluginGuest : public NotificationObserver,
// Exposes the protected web_contents() from WebContentsObserver.
WebContentsImpl* GetWebContents();
- // Kill the guest process.
- void Terminate();
Charlie Reis 2013/04/04 21:48:46 Wow, how did that stick around unimplemented? Tha
Fady Samuel 2013/04/04 22:35:15 It wasn't getting called.
-
// Overridden in tests.
virtual void SetDamageBuffer(
const BrowserPluginHostMsg_ResizeGuest_Params& params);
@@ -376,10 +373,6 @@ class CONTENT_EXPORT BrowserPluginGuest : public NotificationObserver,
#if defined(OS_MACOSX)
void OnShowPopup(const ViewHostMsg_ShowPopup_Params& params);
#endif
- void OnShowView(int route_id,
- WindowOpenDisposition disposition,
- const gfx::Rect& initial_bounds,
- bool user_gesture);
void OnShowWidget(int route_id, const gfx::Rect& initial_pos);
// Overriden in tests.
virtual void OnTakeFocus(bool reverse);

Powered by Google App Engine
This is Rietveld 408576698