Browser Plugin: Simplify NewWindow code

content/browser/browser_plugin/browser_plugin_guest.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A BrowserPluginGuest is the browser side of a browser <--> embedder
 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder
 // renderer side of browser <--> embedder renderer communication.
 //
 // BrowserPluginGuest lives on the UI thread of the browser process. It has a
 // helper, BrowserPluginGuestHelper, which is a RenderViewHostObserver. The
@@ skipping 177 matching lines @@
                               const FileChooserParams& params) OVERRIDE;
   virtual bool ShouldFocusPageAfterCrash() OVERRIDE;
   virtual void RequestMediaAccessPermission(
       WebContents* web_contents,
       const MediaStreamRequest& request,
       const MediaResponseCallback& callback) OVERRIDE;
 
   // Exposes the protected web_contents() from WebContentsObserver.
   WebContentsImpl* GetWebContents();
 
-  // Kill the guest process.
-  void Terminate();

[Charlie Reis, 2013/04/04 21:48:46]

Wow, how did that stick around unimplemented?  Thanks for catching the dead
code.

[Fady Samuel, 2013/04/04 22:35:15]

It wasn't getting called.

-
   // Overridden in tests.
   virtual void SetDamageBuffer(
       const BrowserPluginHostMsg_ResizeGuest_Params& params);
 
   gfx::Point GetScreenCoordinates(const gfx::Point& relative_position) const;
 
   // Helper to send messages to embedder. This methods fills the message with
   // the correct routing id.
   // Overridden in test implementation since we want to intercept certain
   // messages for testing.
@@ skipping 158 matching lines @@
   void OnHandleInputEventAck(
       WebKit::WebInputEvent::Type event_type,
       InputEventAckState ack_result);
   void OnHasTouchEventHandlers(bool accept);
   void OnSetCursor(const WebCursor& cursor);
   // On MacOSX popups are painted by the browser process. We handle them here
   // so that they are positioned correctly.
 #if defined(OS_MACOSX)
   void OnShowPopup(const ViewHostMsg_ShowPopup_Params& params);
 #endif
-  void OnShowView(int route_id,
-                  WindowOpenDisposition disposition,
-                  const gfx::Rect& initial_bounds,
-                  bool user_gesture);
   void OnShowWidget(int route_id, const gfx::Rect& initial_pos);
   // Overriden in tests.
   virtual void OnTakeFocus(bool reverse);
   void OnUpdateDragCursor(WebKit::WebDragOperation operation);
   void OnUpdateFrameName(int frame_id,
                          bool is_top_level,
                          const std::string& name);
   void OnUpdateRect(const ViewHostMsg_UpdateRect_Params& params);
 
   // Helpers for |OnRespondPermission|.
@@ skipping 59 matching lines @@
 
   typedef std::map<int, base::Callback<void(bool)> > DownloadRequestMap;
   DownloadRequestMap download_request_callback_map_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_