Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: minidump/minidump_thread_writer.cc

Issue 1364803004: win: Save contents of TEBs allowing !teb and !gle to work in windbg (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@dump-without-crashing
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: minidump/minidump_thread_writer.cc
diff --git a/minidump/minidump_thread_writer.cc b/minidump/minidump_thread_writer.cc
index a36d76144263163a281b08acb9e276dd11f5f76c..3e7062507014df604788792fb1562fda1c4f2ed6 100644
--- a/minidump/minidump_thread_writer.cc
+++ b/minidump/minidump_thread_writer.cc
@@ -149,6 +149,7 @@ void MinidumpThreadListWriter::InitializeFromSnapshot(
auto thread = make_scoped_ptr(new MinidumpThreadWriter());
thread->InitializeFromSnapshot(thread_snapshot, thread_id_map);
AddThread(thread.Pass());
+ memory_list_writer_->AddFromSnapshot(thread_snapshot->ExtraMemory());
Mark Mentovai 2015/09/29 22:14:04 For purposes of locality in the minidump file, I’d
scottmg 2015/09/30 18:54:11 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698