win: Save contents of TEBs allowing !teb and !gle to work in windbg

minidump/minidump_thread_writer.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 131 matching lines @@
     MinidumpThreadIDMap* thread_id_map) {
   DCHECK_EQ(state(), kStateMutable);
   DCHECK(threads_.empty());
 
   BuildMinidumpThreadIDMap(thread_snapshots, thread_id_map);
 
   for (const ThreadSnapshot* thread_snapshot : thread_snapshots) {
     auto thread = make_scoped_ptr(new MinidumpThreadWriter());
     thread->InitializeFromSnapshot(thread_snapshot, thread_id_map);
     AddThread(thread.Pass());
+    memory_list_writer_->AddFromSnapshot(thread_snapshot->ExtraMemory());

[Mark Mentovai, 2015/09/29 22:14:04]

For purposes of locality in the minidump file, I’d like to keep the thread
stacks contiguous in the minidump file. So this ExtraMemory() add should be in a
separate loop that runs after all of the AddThread() calls are done.

I’ve got this idea that a future minidump reader might be able to make some
sense out of incomplete files, so I’d like the more important stuff like thread
stack memory to ride up front, and the less important stuff like miscellaneous
memory regions to follow.

[scottmg, 2015/09/30 18:54:11]

Done.

   }
 }
 
 void MinidumpThreadListWriter::SetMemoryListWriter(
     MinidumpMemoryListWriter* memory_list_writer) {
   DCHECK_EQ(state(), kStateMutable);
   DCHECK(threads_.empty());
 
   memory_list_writer_ = memory_list_writer;
 }
@@ skipping 60 matching lines @@
   }
 
   return file_writer->WriteIoVec(&iovecs);
 }
 
 MinidumpStreamType MinidumpThreadListWriter::StreamType() const {
   return kMinidumpStreamTypeThreadList;
 }
 
 }  // namespace crashpad