Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1364643002: Remove unused function in presubmit script (Closed)

Created:
5 years, 3 months ago by thefourtheye
Modified:
5 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused function in presubmit script FilterFiles function is defined but unused in the code. BUG= R=machenbach@chromium.org Committed: https://crrev.com/4e05854068414671bd8a60b11154215332e99e1b Cr-Commit-Position: refs/heads/master@{#30882}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unused FilterFiles function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
thefourtheye
5 years, 3 months ago (2015-09-23 02:29:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364643002/1
5 years, 3 months ago (2015-09-23 04:42:00 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-09-23 04:42:02 UTC) #5
Michael Achenbach
lgtm with comment: https://codereview.chromium.org/1364643002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/1364643002/diff/1/AUTHORS#newcode105 AUTHORS:105: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> nit: This list ...
5 years, 3 months ago (2015-09-23 07:24:01 UTC) #6
thefourtheye
On 2015/09/23 07:24:01, Michael Achenbach wrote: > lgtm with comment: > > https://codereview.chromium.org/1364643002/diff/1/AUTHORS > File ...
5 years, 3 months ago (2015-09-23 09:27:48 UTC) #7
Michael Achenbach
lgtm
5 years, 3 months ago (2015-09-23 09:29:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364643002/20001
5 years, 3 months ago (2015-09-23 10:27:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 10:52:40 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 10:52:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e05854068414671bd8a60b11154215332e99e1b
Cr-Commit-Position: refs/heads/master@{#30882}

Powered by Google App Engine
This is Rietveld 408576698