PRESUBMIT.py - Issue 1364643002: Remove unused function in presubmit script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1364643002: Remove unused function in presubmit script (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove unused FilterFiles function Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index c9a8a99de4c3e1cca190b563f69e6c5918304c8a..ab9bba88455906ecb61b6f90cc107b7171f2fc33 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -233,7 +233,6 @@ def _SkipTreeCheck(input_api, output_api):

"""Check the env var whether we want to skip tree check.

Only skip if include/v8-version.h has been updated."""

src_version = 'include/v8-version.h'

- FilterFile = lambda file: file.LocalPath() == src_version

if not input_api.AffectedSourceFiles(

lambda file: file.LocalPath() == src_version):

return False

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »