Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13646003: DevTools: Remove ENABLE(INSPECTOR) and ENABLE(JAVASCRIPT_DEBUGGER) from the code. (Closed)

Created:
7 years, 8 months ago by loislo
Modified:
7 years, 8 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, loislo+blink_chromium.org, jsbell, alecflett, yurys+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dgrogan
Visibility:
Public.

Description

DevTools: Remove ENABLE(INSPECTOR) and ENABLE(JAVASCRIPT_DEBUGGER) from the code. BUG=226934 R=pfeldman, yurys TEST=build Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147618

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1455 lines) Patch
M Source/WebCore/bindings/v8/JavaScriptCallFrame.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/JavaScriptCallFrame.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/PageScriptDebugServer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/PageScriptDebugServer.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptController.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptDebugServer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptDebugServer.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptGCEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptGCEvent.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptObject.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptProfile.h View 1 2 chunks +1 line, -8 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptProfile.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptProfiler.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptValue.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/SerializedScriptValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/SerializedScriptValue.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/V8AbstractEventListener.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/v8/V8Initializer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/V8PerIsolateData.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/v8/V8PerIsolateData.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/WorkerScriptDebugServer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/WorkerScriptDebugServer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8ConsoleCustom.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8InjectedScriptManager.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/dom/CharacterData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/dom/ContainerNodeAlgorithms.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/dom/Element.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/dom/Node.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/ConsoleMessage.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/ContentSearchUtils.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/ContentSearchUtils.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/DOMEditor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/DOMEditor.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/DOMPatchSupport.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/DOMPatchSupport.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/HeapGraphSerializer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/HeapGraphSerializer.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/IdentifiersFactory.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/WebCore/inspector/IdentifiersFactory.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InjectedScript.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InjectedScript.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptBase.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptBase.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptCanvasModule.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptCanvasModule.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptHost.h View 4 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptHost.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptManager.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptModule.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InjectedScriptModule.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorApplicationCacheAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorBaseAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorCSSAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorCSSAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorCanvasAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorCanvasAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorCanvasInstrumentation.h View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/WebCore/inspector/InspectorClient.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorConsoleAgent.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorConsoleAgent.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/InspectorConsoleInstrumentation.h View 1 chunk +0 lines, -101 lines 0 comments Download
M Source/WebCore/inspector/InspectorController.h View 4 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/inspector/InspectorController.cpp View 1 9 chunks +0 lines, -16 lines 0 comments Download
M Source/WebCore/inspector/InspectorCounters.h View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/WebCore/inspector/InspectorCounters.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMDebuggerAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMStorageAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseInstrumentation.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorDatabaseResource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorDebuggerAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorDebuggerAgent.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/InspectorFileSystemAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorFileSystemAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendHost.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorHeapProfilerAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorHistory.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorHistory.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorIndexedDBAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorIndexedDBAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorInputAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorInputAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorInstrumentation.h View 11 chunks +0 lines, -672 lines 0 comments Download
M Source/WebCore/inspector/InspectorInstrumentation.cpp View 1 12 chunks +0 lines, -36 lines 0 comments Download
M Source/WebCore/inspector/InspectorLayerTreeAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorLayerTreeAgent.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorMemoryAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorMemoryAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorOverlay.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorPageAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorPageAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorProfilerAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorProfilerAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorResourceAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorResourceAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorRuntimeAgent.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/inspector/InspectorRuntimeAgent.cpp View 1 10 chunks +0 lines, -24 lines 0 comments Download
M Source/WebCore/inspector/InspectorState.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorState.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorStyleSheet.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorStyleSheet.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorStyleTextEditor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorStyleTextEditor.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorTimelineAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorTimelineAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorWorkerAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorWorkerResource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InstrumentingAgents.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InstrumentingAgents.cpp View 1 4 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/inspector/MemoryInstrumentationImpl.cpp View 1 3 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/inspector/NetworkResourcesData.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/NetworkResourcesData.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/PageConsoleAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/PageConsoleAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/PageDebuggerAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/PageDebuggerAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/PageRuntimeAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/PageRuntimeAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/ScriptCallFrame.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/ScriptCallFrame.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/ScriptCallStack.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/ScriptCallStack.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/ScriptDebugListener.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/ScriptGCEventListener.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/TimelineRecordFactory.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/TimelineTraceEventProcessor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/TimelineTraceEventProcessor.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/WorkerConsoleAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/WorkerConsoleAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/WorkerDebuggerAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/WorkerDebuggerAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/WorkerInspectorController.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/WebCore/inspector/WorkerInspectorController.cpp View 5 chunks +1 line, -7 lines 0 comments Download
M Source/WebCore/inspector/WorkerRuntimeAgent.h View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/WorkerRuntimeAgent.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/WebCore/loader/DocumentThreadableLoader.cpp View 1 8 chunks +1 line, -16 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/loader/ResourceLoader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/appcache/ApplicationCacheGroup.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp View 1 6 chunks +1 line, -18 lines 0 comments Download
M Source/WebCore/loader/appcache/ApplicationCacheHost.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/loader/appcache/ApplicationCacheHost.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/page/Console.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/page/Console.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/page/ContextMenuController.cpp View 7 chunks +0 lines, -12 lines 0 comments Download
M Source/WebCore/page/FrameView.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/page/MemoryInfo.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/page/Page.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/page/Page.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/platform/ContextMenuItem.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/ThreadGlobalData.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/ThreadGlobalData.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/testing/Internals.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/testing/Internals.cpp View 8 chunks +0 lines, -16 lines 0 comments Download
M Source/WebCore/workers/DefaultSharedWorkerRepository.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/workers/WorkerContext.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/workers/WorkerContext.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/workers/WorkerContextProxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/workers/WorkerMessagingProxy.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/workers/WorkerMessagingProxy.cpp View 6 chunks +0 lines, -20 lines 0 comments Download
M Source/WebCore/workers/WorkerReportingProxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/workers/WorkerThread.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
loislo
7 years, 8 months ago (2013-04-05 12:03:54 UTC) #1
yurys
You should also remove mentions of the variables from gyp files, .idl, FeatureDefines.h and probably ...
7 years, 8 months ago (2013-04-05 12:11:20 UTC) #2
loislo
On 2013/04/05 12:11:20, Yury Semikhatsky wrote: > You should also remove mentions of the variables ...
7 years, 8 months ago (2013-04-05 13:00:25 UTC) #3
pfeldman
lgtm
7 years, 8 months ago (2013-04-05 13:19:35 UTC) #4
yurys
lgtm
7 years, 8 months ago (2013-04-05 13:25:19 UTC) #5
loislo
7 years, 8 months ago (2013-04-05 13:40:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r147618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698