Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: test/variables/empty/gyptest-empty.py

Issue 1364373004: Fix infinite loop on empty variable name. (Closed) Base URL: https://chromium.googlesource.com/external/gyp@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/variables/empty/empty.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/variables/empty/gyptest-empty.py
diff --git a/test/actions-multiple-outputs/src/touch.py b/test/variables/empty/gyptest-empty.py
old mode 100644
new mode 100755
similarity index 54%
copy from test/actions-multiple-outputs/src/touch.py
copy to test/variables/empty/gyptest-empty.py
index bc61267f39cea074a7be4ce490407a5f1249687b..4cbe166fdc3624c62c6d8075abd6944a934f4e8f
--- a/test/actions-multiple-outputs/src/touch.py
+++ b/test/variables/empty/gyptest-empty.py
@@ -1,16 +1,19 @@
#!/usr/bin/env python
-#
+
# Copyright (c) 2015 Google Inc. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+"""
+Test that empty variable names don't cause infinite loops.
+"""
+
import os
-import sys
-"""Cross-platform touch."""
+import TestGyp
+
+test = TestGyp.TestGyp()
+
+test.run_gyp('empty.gyp')
-for fname in sys.argv[1:]:
- if os.path.exists(fname):
- os.utime(fname, None)
- else:
- open(fname, 'w').close()
+test.pass_test()
« no previous file with comments | « test/variables/empty/empty.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698