Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1364373004: Fix infinite loop on empty variable name. (Closed)

Created:
5 years, 2 months ago by bnoordhuis
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M pylib/gyp/input.py View 1 chunk +1 line, -1 line 0 comments Download
A + test/variables/empty/empty.gyp View 1 chunk +4 lines, -3 lines 0 comments Download
A + test/variables/empty/empty.gypi View 1 chunk +5 lines, -2 lines 0 comments Download
A + test/variables/empty/gyptest-empty.py View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bnoordhuis
5 years, 2 months ago (2015-09-25 19:39:55 UTC) #2
Mark Mentovai
LGTM
5 years, 2 months ago (2015-09-25 20:27:34 UTC) #3
Mark Mentovai
5 years, 2 months ago (2015-09-25 20:30:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
265f495cc3a3cf59004edbfd4fca6a3cc4315526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698