sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 13642002: Make sure required type arguments are given when using factories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 13642002: Make sure required type arguments are given when using factories. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | sdk/lib/_internal/compiler/implementation/universe/universe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

index 9eed786f2c3068cd6b1905f924133cdde5fcf4c6..f0e8c7ff39edf2d1c486e8710674282319fe9aa5 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

@@ -3357,6 +3357,9 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

}

+ if (constructor.isFactoryConstructor() && !type.typeArguments.isEmpty) {

+ compiler.enqueuer.codegen.registerFactoryWithTypeArguments(elements);

+ }

HType elementType = computeType(constructor);

HInstruction newInstance = new HInvokeStatic(inputs, elementType);

pushWithPosition(newInstance, node);