sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 13642002: Make sure required type arguments are given when using factories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 13642002: Make sure required type arguments are given when using factories. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index e6fd47862ac1280627bedfdbbf339ae86f10a11c..d8a42cff3c64461817d1ea8719e6a74762e2f89a 100644

--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -2538,9 +2538,11 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {

// and only declaration elements may be registered.

world.registerStaticUse(constructor.declaration);

ClassElement cls = constructor.getEnclosingClass();

- // [cls] might be the implementation element and only declaration elements

- // may be registered.

- world.registerInstantiatedType(mapping.getType(node), mapping);

+ InterfaceType type = mapping.getType(node);

+ world.registerInstantiatedType(type, mapping);

+ if (constructor.isFactoryConstructor() && !type.typeArguments.isEmpty) {

+ world.registerFactoryWithTypeArguments(mapping);

+ }

if (cls.isAbstract(compiler)) {

compiler.backend.registerAbstractClassInstantiation(mapping);

}