Material PDF: Support RTL languages

Material PDF: Support RTL languages

Among a number of minor changes to padding and alignmnent, we also switch
viewer-zoom-toolbar to use CSS transitions rather than neon-animation, as
it's much easier to make RTL compatible and more concise code. We also
switch from number input in the page selector, as it does not have
suitable localization support.

Disabling presubmit since it doesn't like paper-tooltip

BUG=506035
NOPRESUBMIT=true

Committed: https://crrev.com/60359baa563144ece74a4f8f3e19632b339a7c50
Cr-Commit-Position: refs/heads/master@{#351031}

[tsergeant, 2015-09-24 07:13:07]

tsergeant@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2015-09-25 00:07:59]

I just skimmed this but a lot of the changes look magical to me (css! :) Is it
ok if we go through them together on Monday?

[tsergeant, 2015-09-25 00:22:40]

On 2015/09/25 at 00:07:59, raymes wrote:
> I just skimmed this but a lot of the changes look magical to me (css! :) Is it
ok if we go through them together on Monday?

No problem!

[raymes, 2015-09-28 03:14:53]

lgtm

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.css
(right):

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.css:15:
:host-context([dir=rtl]) #wrapper.closed {
nit: should use attribute :host-context([dir-rtl]) :host([closed])

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
chrome/browser/resources/pdf/pdf.js:753: if (document.dir == 'ltr')
nit: add comment about why this is the case
add {} because it's a multiline if

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/pdf/toolbar_manager.js (right):

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
chrome/browser/resources/pdf/toolbar_manager.js:47: e.x > window.innerWidth -
SIDE_TOOLBAR_REVEAL_DISTANCE_RIGHT) &&
nit: split into multiple statements.

[tsergeant, 2015-09-28 04:26:33]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2015-09-28 04:26:34]

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.css
(right):

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.css:15:
:host-context([dir=rtl]) #wrapper.closed {
On 2015/09/28 at 03:14:53, raymes wrote:
> nit: should use attribute :host-context([dir-rtl]) :host([closed])

Done

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
chrome/browser/resources/pdf/pdf.js:753: if (document.dir == 'ltr')
On 2015/09/28 at 03:14:53, raymes wrote:
> nit: add comment about why this is the case
> add {} because it's a multiline if

Done

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/pdf/toolbar_manager.js (right):

https://codereview.chromium.org/1364163002/diff/40001/chrome/browser/resource...
chrome/browser/resources/pdf/toolbar_manager.js:47: e.x > window.innerWidth -
SIDE_TOOLBAR_REVEAL_DISTANCE_RIGHT) &&
On 2015/09/28 at 03:14:53, raymes wrote:
> nit: split into multiple statements.

Done.

[tsergeant, 2015-09-28 04:26:34]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1364163002/#ps60001
(title: "Review comments")

[commit-bot: I haz the power, 2015-09-28 04:26:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364163002/60001

[commit-bot: I haz the power, 2015-09-28 04:27:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 04:27:56]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2015-09-28 04:42:27]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2015-09-28 04:42:27]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1364163002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-09-28 04:42:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364163002/80001

[commit-bot: I haz the power, 2015-09-28 07:56:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-28 07:57:02]

Patchset 5 (id:??) landed as
https://crrev.com/60359baa563144ece74a4f8f3e19632b339a7c50
Cr-Commit-Position: refs/heads/master@{#351031}