snapshot/minidump/process_snapshot_minidump.cc - Issue 1364053002: win: Save contents of PEB to minidump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/minidump/process_snapshot_minidump.cc

Issue 1364053002: win: Save contents of PEB to minidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@save-teb

Patch Set: test Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/minidump/process_snapshot_minidump.cc

diff --git a/snapshot/minidump/process_snapshot_minidump.cc b/snapshot/minidump/process_snapshot_minidump.cc

index 5344118c169f91956d92a213230dbc74bf92d9ca..bf43da417885b9806e009feebb7033d49f8ca4ed 100644

--- a/snapshot/minidump/process_snapshot_minidump.cc

+++ b/snapshot/minidump/process_snapshot_minidump.cc

@@ -156,6 +156,12 @@ const SystemSnapshot* ProcessSnapshotMinidump::System() const {

return nullptr;

}

+const MemorySnapshot* ProcessSnapshotMinidump::Peb() const {

+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);

+ NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10

+ return nullptr;

std::vector<const ThreadSnapshot*> ProcessSnapshotMinidump::Threads() const {

INITIALIZATION_STATE_DCHECK_VALID(initialized_);

NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10